[U-Boot] [PATCH 2/2] OMAP3: Print correct silicon revision

Dirk Behme dirk.behme at googlemail.com
Fri Apr 24 22:40:56 CEST 2009


Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 18:49 Fri 24 Apr     , Dirk Behme wrote:
>> Sanjeev Premi wrote:
>>> The function display_board_info() displays incorrect
>>> silicon revision - based on the return value from
>>> function get_cpu_rev().
>>>
>>> This patch fixes the problem.
>>>
>>> Signed-off-by: Sanjeev Premi <premi at ti.com>
>> Signed-off-by: Dirk Behme <dirk.behme at googlemail.com>
>> Tested-by: Dirk Behme <dirk.behme at googlemail.com>
> 
> why the twice?

I wanted to mention that I helped developing these patches and that I 
tested them on real HW.

http://kerneltrap.org/node/8329:

"The Signed-off-by: tag implies that the signer was involved in the 
development of the patch"

"Tested-by ... it's very useful information to have. For a start, it 
tells you who has the hardware and knows how to build ..."

If you think one is enough, remove what you don't like ;)

Dirk



More information about the U-Boot mailing list