[U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

Wolfgang Denk wd at denx.de
Mon Apr 27 12:43:36 CEST 2009


Dear Ricardo Ribalda Delgado,

In message <aa76a2be0904270317h531e626bn4be3423963aa755 at mail.gmail.com> you wrote:
> 
> 
> > Then please write this in the commit message of the patch.
> 
> It is already written in the ubifs patch (#2) Shall I also add this to
> this patch (#1), that only touches the gunzip file?

How should anybody know why the gunzip file gets changed if there is
no explanation given at all in the commit message?

How should he know that some other patch might be related when all he
has is the commit logs?


Please add an explanation to the patch that says what the patch is
changing, and why.

Please re-read http://www.denx.de/wiki/U-Boot/Patches

It says:

	In the message body, include a description of your changes.

	    * For bug fixes: a description of the bug and how your
	      patch fixes this bug. Please try to include a way of
	      demonstrating that the patch actually fixes something.
	    * For new features: a description of the feature and
	      your implementation.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many QA engineers does it take to screw in a lightbulb? 3:  1  to
screw it in and 2 to say "I told you so" when it doesn't work.


More information about the U-Boot mailing list