[U-Boot] [PATCHv3 0/3] OMAP3: Board specific updates

Premi, Sanjeev premi at ti.com
Mon Apr 27 17:26:48 CEST 2009


> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Premi, Sanjeev
> Sent: Monday, April 27, 2009 8:49 PM
> To: Dirk Behme
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCHv3 0/3] OMAP3: Board specific updates
> 
> 
> > -----Original Message-----
> > From: Dirk Behme [mailto:dirk.behme at googlemail.com] 
> > Sent: Monday, April 27, 2009 8:47 PM
> > To: Premi, Sanjeev
> > Cc: u-boot at lists.denx.de
> > Subject: Re: [U-Boot] [PATCHv3 0/3] OMAP3: Board specific updates
> > 
> > Hi Premi,
> > 
> > Sanjeev Premi wrote:
> > > This series contains 3 specific updates:
> > >  - Use common API to print cpu and board
> > >    related information.
> > >  - Remove unused board type definitions.
> > >  - Print correct silicon revision in the
> > >    board information
> > > 
> > > These updates have been tested on OMAP3EVM
> > > with ES 3.0 and ES3.1 silicon versions.
> > > 
> > > Thanks to Dirk Behme [dirk.behme at googlemail.com]
> > > for converting a quick hack into complete
> > > solution.
> > > 
> > > Sanjeev Premi (3):
> > >   OMAP3: Use functions print_cpuinfo() and checkboard()
> > >   OMAP3: Remove unused board-types
> > >   OMAP3: Print correct silicon revision
> > 
> > Applying all 3 patches I get
> > 
> > sys_info.c: In function 'print_cpuinfo':
> > sys_info.c:297: warning: no return statement in function returning 
> > non-void
> > board.c: In function 'checkboard':
> > board.c:349: warning: implicit declaration of function 'is_mem_sdr'
> > board.c:357: warning: no return statement in function 
> > returning non-void
> > 
> 
> I usually do a distclean followed by make; but let me do this again.

Yeah. found it... a miss in interactive commit 3/3.

Should I re-submit the whole series?
OR
Is it okay to re-send just the last one.

~sanjeev

> 
> ~sanjeev
> 
> > Not sure which patch it is, though.
> > 
> > Best regards
> > 
> > Dirk
> > 
> > Btw.: You can easily check this by doing a
> > 
> > ./MAKEALL ARM_CORTEX_A8
> > 
> > 
> > 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 
> 


More information about the U-Boot mailing list