[U-Boot] [PATCH] include/ns16550.h: Unify structure declaration for registers

Detlev Zundel dzu at denx.de
Mon Apr 27 18:09:42 CEST 2009


Hello Shinya,

>> If there's no good alternatives, I think reverting is a good idea
>> because there must be other platforms affected by this change.

I just checked again - the "problematic" cases can only be REG_SIZE 2
and 4:

[dzu at pollux u-boot-testing (master)]$ grep CONFIG_SYS_NS16550_REG_SIZE include/configs/* | grep -v 'REG_SIZE.*\(1\|(-4)\|-4\|-8\)'
include/configs/AP1000.h:#define CONFIG_SYS_NS16550_REG_SIZE    4
include/configs/CU824.h:#define CONFIG_SYS_NS16550_REG_SIZE     4
include/configs/mcc200.h:#define CONFIG_SYS_NS16550_REG_SIZE    4
include/configs/ppmc7xx.h: * CONFIG_SYS_NS16550_REG_SIZE - 64-bit accesses to 8-bit port
include/configs/xilinx-ppc.h:#define CONFIG_SYS_NS16550_REG_SIZE 4

CU824 incidentally is the platform that I tested the patch on (PowerPC),
ppmc7xx is a false positive, so only three platforms remain.  I'm almost
100% sure that mcc200 also works, as it is also a PowerPC platform
comparable to CU824. Is AP1000 your platform?

We should really work to get these platforms in order, the fallout is
not as big as may have been expected...

Cheers
  Detlev

-- 
Summary [of object-oriented programming in Perl 5]
That's all about there is to it. Now you just need to go off and buy a
book about object-oriented design methodology, and bang  your forehead
with it for the next six months or so.    Larry Wall [Creator of Perl]
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de


More information about the U-Boot mailing list