[U-Boot] [PATCH 1/2] LPC2468 support

[Wolfgang Denk]

Dear Stefan Roese,

In message <200904270927.29232.sr at denx.de> you wrote:
>
> I took a quick look at the flash "driver". The main functions  
> lpc24xx_flash_erase() and lpc24xx_write_buff() are not even referenced 
> somewhere in this patch. They seem to be used in the 2nd patch (2/2) though. 
> It's hard to really understand what's going on here. So this flash driver 
> part really needs some sort of documentation how it's supposed to work.
> 
> And I also think this driver (as all FLASH related drivers) should be moved 
> into drivers/mtd instead.

Into drivers/mtd? Even if it's not a  MTD driver? This doesn't make
mnuch sense to me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Politics:  A  strife  of  interests  masquerading  as  a  contest  of
principles. The conduct of public affairs for private advantage.
- Ambrose Bierce