[U-Boot] [PATCH 3/3] ubifs: BUG: Blocks commpressed with zlib

Wolfgang Denk wd at denx.de
Tue Apr 28 01:25:22 CEST 2009


Dear Ricardo Ribalda Delgado,

In message <aa76a2be0904270925kc67bf77i1b3f53c4afbc394f at mail.gmail.com> you wrote:
> 
> > If the only purpose of zunzip() is to be used here, then why do we not
> > make the parameters fit the intended purpose, thus avoiding an
> > additional wrapper?
> 
> The purpose of zunzip is to use it in more places. Like Mike Frysinger said:
> 
> <Mike>
> this really should be a common function not specific to ubifs as there are
> many other opportunities for things to be compressed directly with zlib and
> not through gzip (splash/video images come to mind).
> </Mike>
> 
> Also, in order to be "parameter compatible" with lzo, we should keep
> this wrapper (am I right Stefan?)

But cannot these other pleaces use a parameter-compatible version as
well, or even better (because they might then eventually use lzo as
well, at least more easily) ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hiring experienced unix people is  like  a  built-in  filter  against
idiots. Hiring experienced NT people provides no such guarantee.
            -- Miguel Cruz in WgL96.349$CC.122704 at typhoon2.ba-dsg.net


More information about the U-Boot mailing list