[U-Boot] [PATCH] bmp_logo: Check return value of fread()

Peter Tyser ptyser at xes-inc.com
Tue Apr 28 01:53:15 CEST 2009


On Mon, 2009-04-27 at 19:41 -0400, Mike Frysinger wrote:
> On Monday 27 April 2009 19:18:21 Wolfgang Denk wrote:
> > In message Peter Tyser wrote:
> > > <base64 stuff>
> > ...
> >
> > Please do not post base64 encoded messages.  Next time I will ignore
> > such patches.
> 
> it's due to unicode yet again:
> 
> > > bmp_logo.c: In function `main':
> 
> those ticks are probably the left & right unicode ticks that pretty much all 
> GNU tools use.  it's pretty hard for people to catch these things in the 
> normal flow of git usage considering using a unicode locale setting and a GNU 
> system is by and far the norm.

Ahhhh, thanks for the enlightenment - that makes sense.  I use urxvt and
pasted the output of a gcc warning in the commit message.

The copies cc-ed to myself come through just fine as utf-8 fwiw.  Does
that imply the denx.de servers convert unicode messages to base64?

In general, what's the proper workaround so things like this don't
happen?

Peter



More information about the U-Boot mailing list