[U-Boot] [PATCH] bmp_logo: Check return value of fread()

[Peter Tyser]

On Tue, 2009-04-28 at 11:49 -0400, Mike Frysinger wrote:
> On Tuesday 28 April 2009 11:06:06 Peter Tyser wrote:
> > > > The copies cc-ed to myself come through just fine as utf-8 fwiw.  Does
> > > > that imply the denx.de servers convert unicode messages to base64?
> > >
> > > This is in the headers of your message:
> > >
> > > 	Content-Type: text/plain; charset="utf-8"
> > > 	Content-Transfer-Encoding: base64
> > >
> > > I don't think anything converted anything. It arrived as you sent it.
> >
> > 'git send-email' cc-ed me a copy of the patch as well as sent it to the
> > mailing list.  The copy cc-ed directly to me had the following headers:
> >
> > Content-Type: text/plain; charset=utf-8
> > Content-Transfer-Encoding: 8bit
> >
> > However, the copy received from denx.de had the headers:
> >
> > Content-Type: text/plain; charset=utf-8
> > Content-Transfer-Encoding: 8bit
> > X-MIME-Autoconverted: from base64 to 8bit by xes-inc.com id n3OL05sk002907
> >
> > Based on the "Autoconverted" line my guess is the email from denx.de was
> > in base64 and our email server automatically converted it to 8bit
> > encoding.
> 
> hmm, maybe newer versions of git dont convert to base64 ... i tested 1.6.2.3 
> and it doesnt mung the subject or the content anymore.  the subject however 
> does get encoded with =?utf-8?, but there isnt anything we can do about that 
> as that is part of the e-mail spec.

Yeah, in the original patch I see (git 1.6.2.1):
...
Subject: [PATCH] bmp_logo: Check return value of fread()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Add basic error handling to fread() function calls.  This prevents
...

> > > You just don't see it.
> >
> > I (think I) see base64 coming from denx.de, but not from our mail
> > server.
> >
> > The headers imply that a server outside xes-inc.com converted the
> > 8bit/utf-8 message into base64/utf-8.  Perhaps denx.de doesn't support
> > the 8BITMIME SMTP extension?  Or something along those lines?  Or am I
> > missing something?
> 
> the header says "by xes-inc.com" which kind of implies it was your e-mail 
> server doing it ...

The header in the email from denx.de says "X-MIME-Autoconverted: from
base64 to 8bit by xes-inc.com" which implies to me the inbound email
from denx.de was base64.  In contrast the email from xes-inc.com didn't
have the "base64 to 8bit" message which implies xes-inc.com sent it out
in 8bit/utf-8 as desired.

> you could try sending me the aforementioned patch directly and see if it 
> happens when i get it ...

Will do.

Thanks,
Peter