[U-Boot] [PATCH 1/3][Net][ARM] Moved Davinci Ethernet driver to drivers/net

Ben Warren biggerbadderben at gmail.com
Tue Apr 28 22:04:59 CEST 2009


David Brownell wrote:
> On Tuesday 28 April 2009, Ben Warren wrote:
>   
>>  The driver has been renamed dm644x_emac.c
>>     
>
> Let me suggest "davinci_emac.c" ... the same controller
> is in some non-dm644x DaVinci silicon (like dm365), and
> a gigabit flavor is in the dm6467 chip.
>
>
>   
OK.  I named it this because the top of the file mentioned it was ripped 
off from 'dm644x_emac.c' (not Linux)
>>  
>> -COBJS  = timer.o ether.o lxt972.o dp83848.o
>> +COBJS  = timer.o lxt972.o dp83848.o
>>  SOBJS  = lowlevel_init.o reset.o
>>     
>
> Given the recent cleanups in cpu/arm926ejs/davinci/Makefile,
> that won't quite apply.  I suggest you pull some of the
> changes from arm-next.
>   
OK, I'll look into that.
> Procedure note:  this is exactly why Linux now has a
> shared "-next" tree ... to make sure interdependencies
> between development branches can be sorted out before
> the next merge window, so the merge window can be spent
> addressing more substantive issues (if any).
>
>   
Sounds good.  I believe there is a 'next' branch on the U-boot mainline, 
and quite often we do use it, but probably should do so earlier in the 
process.

Thanks for the help and advice!
Ben


More information about the U-Boot mailing list