[U-Boot] [PATCH v2] ARM DaVinci: Adding DM357 Support

[Paulraj, Sandeep]

Dave,
    Please see inline.

> -----Original Message-----
> From: David Brownell [mailto:david-b at pacbell.net]
> Sent: Wednesday, April 29, 2009 2:09 PM
> To: Paulraj, Sandeep; u-boot at lists.denx.de
> Cc: davinci-linux-open-source at linux.davincidsp.com
> Subject: Re: [PATCH v2] ARM DaVinci: Adding DM357 Support
> 
> On Wednesday 29 April 2009, s-paulraj at ti.com wrote:
> > +.globl dv_board_init
> > +dv_board_init:
> > +
> > +       mov     pc, lr
[Sandeep] OK I will remove this
> 
> Surely you can eliminate a file containing only such a
> useless NOP function...
> 
> 
> > +#define CONFIG_SOC_DM644X
[Sandeep] this is correct. It is a type of DM644x.
> 
> Hmm, I'd have expected a CONFIG_SOC_DM357.  No DSP
> (and so why were you checking for DSPLINK?) on these
> chips, right?  Just an HMJCP (resembling DM365).
[Sandeep] I will remove this

Any other comments?
> 
> - Dave

Thanks,
Sandeep