[U-Boot] [PATCH 4/6] fsl_esdhc: Add device tree fixups

Scott Wood scottwood at freescale.com
Thu Apr 30 19:57:52 CEST 2009


On Thu, Apr 30, 2009 at 01:20:11AM +0400, Anton Vorontsov wrote:
> > Isn't there a more global means of doing this?  I don't like having
> > the 8536/8379 in the driver, itself.
> 
> But that's how we prefer bindings nowadays.

Block version numbers are better, if available.

> > Actually, there is.  Move these to the config file.  But there should
> > be a compatible property that works for all esdhc devices.
> 
> Starting from MPC83xx/MPC85xx GPIO controllers, we try to differentiate
> 85xx and 83xx parts.  I.e. 85xx family doesn't specify 83xx family's
> compatible entries, even if the controllers are compatible. I'm just
> following the trend.

I must have missed that memo...

Why would we not recognize the compatibility if it exists?

> So the current scheme is:
> "fsl,device-<chip>", "fsl,device-<first-chip-in-a-family>;
> 
> See this discussion:
> 
> http://ozlabs.org/pipermail/linuxppc-dev/2008-September/062934.html

Bah.  I don't see how it's any more "confusing to show 8610 and 8349 in
the same dev tree" than in is to show, say, 8313 and 8349 in the same
device tree.  The concept of component A being compatible with component
B doesn't somehow get mysterious when the systems involved have a
different type of core.

-Scott


More information about the U-Boot mailing list