[U-Boot] [PATCH] imx27lite: add support for imx27lite board from LogicPD

Wolfgang Denk wd at denx.de
Mon Aug 3 10:19:38 CEST 2009


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090803053218.GA15665 at game.jcrosoft.org> you wrote:
>
...
> > +/* malloc() len */
> > +#define CONFIG_SYS_MALLOC_LEN		(0x10000 + 256 * 1024)
> please do not mix hexa and decimal

Please be reasonable. This is a perfectly valid and easy to read
notation. I see no reason to change this - anything else would
probably be much harder to read.

> > +#define CONFIG_LOADADDR		0xa0800000	/* loadaddr env var */
> > +#define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
> why 2?

Because they do different things.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Where humor is concerned there are no standards -- no  one  can  say
what is good or bad, although you can be sure that everyone will.
- John Kenneth Galbraith


More information about the U-Boot mailing list