[U-Boot] [PATCH] pci/fsl_pci_init: Fold pci_setup_indirect into fsl_pci_init

Wolfgang Denk wd at denx.de
Tue Aug 4 08:07:12 CEST 2009


Dear Kumar Gala,

In message <1249352037-25832-1-git-send-email-galak at kernel.crashing.org> you wrote:
> Every platform that calls fsl_pci_init calls pci_setup_indirect before
> it calls fsl_pci_init.  There isn't any reason to just call it from
> fsl_pci_init and simplify things a bit.
...
> --- a/include/asm-ppc/fsl_pci.h
> +++ b/include/asm-ppc/fsl_pci.h
> @@ -21,7 +21,7 @@
>  #define __FSL_PCI_H_
>  
>  int fsl_pci_setup_inbound_windows(struct pci_region *r);
> -void fsl_pci_init(struct pci_controller *hose);
> +void fsl_pci_init(struct pci_controller *hose, u32 cfg_addr, u32 cfg_data);

There will never be any system where 64 bit addresses may be needed?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The world is no nursery.                              - Sigmund Freud


More information about the U-Boot mailing list