[U-Boot] [PATCH] pci/fsl_pci_init: Fold fsl_pci_setup_inbound_windows into fsl_pci_init

Wolfgang Denk wd at denx.de
Tue Aug 4 08:09:50 CEST 2009


Dear Kumar Gala,

In message <1249352037-25832-2-git-send-email-galak at kernel.crashing.org> you wrote:
> Every platform that calls fsl_pci_init calls fsl_pci_setup_inbound_windows
> before it calls fsl_pci_init.  There isn't any reason to just call it
> from fsl_pci_init and simplify things a bit.
...
> diff --git a/board/atum8548/atum8548.c b/board/atum8548/atum8548.c
> index 7a02cdc..85c0adc 100644
> --- a/board/atum8548/atum8548.c
> +++ b/board/atum8548/atum8548.c
> @@ -216,9 +216,6 @@ pci_init_board(void)
>  		}
>  		printf ("\n");
>  
> -		/* inbound */
> -		r += fsl_pci_setup_inbound_windows(r);
> -
>  		/* outbound memory */
>  		pci_set_region(r++,
>  			       CONFIG_SYS_PCIE1_MEM_BASE,

Now pci_set_region() will see a different value of "r". Is this OK?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
[Doctors and Bartenders], We both get the same two kinds of customers
-- the living and the dying.
	-- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknown


More information about the U-Boot mailing list