[U-Boot] [PATCH] 85xx: Add a 36-bit physical configuration for MPC8536DS

Wolfgang Denk wd at denx.de
Thu Aug 6 21:33:13 CEST 2009


Dear Kumar Gala,

In message <1249573913-1451-1-git-send-email-galak at kernel.crashing.org> you wrote:
> We move all IO addressed (CCSR, localbus, PCI) above the 4G boundary
> to allow for larger memory sizes.
> 
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> ---
>  Makefile                    |    8 ++++-
>  include/configs/MPC8536DS.h |   78 +++++++++++++++++++++++++++++++++++++-----
>  2 files changed, 75 insertions(+), 11 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 54c0b67..8ebdd42 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2406,8 +2406,14 @@ vme8349_config:		unconfig
>  ATUM8548_config:	unconfig
>  	@$(MKCONFIG) $(@:_config=) ppc mpc85xx atum8548
>  
> +MPC8536DS_36BIT_config \
>  MPC8536DS_config:       unconfig
> -	@$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8536ds freescale
> +	@mkdir -p $(obj)include
> +	@if [ "$(findstring _36BIT_,$@)" ] ; then \
> +		echo "#define CONFIG_PHYS_64BIT" >>$(obj)include/config.h ; \
> +		$(XECHO) "... enabling 36-bit physical addressing." ; \
> +	fi
> +	@$(MKCONFIG) -a MPC8536DS ppc mpc85xx mpc8536ds freescale

Argh... You know that I hate such long script-like parts in the top
level Makefile. Please add such logic to the board config file
instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If a train station is a place where a train stops,
                                           then what's a workstation?


More information about the U-Boot mailing list