[U-Boot] [PATCH 6/8] tools: mkimage: Making table_entry code global
Wolfgang Denk
wd at denx.de
Sun Aug 9 22:29:36 CEST 2009
Dear Prafulla Wadaskar,
In message <73173D32E9439E4ABB5151606C3E19E202E121613D at SC-VEXCH1.marvell.com> you wrote:
>
> I have gone through all the feedback that you have provided for this entire patch series.
> Thanks a lot...
Thank you for your pat6ience. Sorry it's such a long story for such a
apparently small addition.
> I tried to maintain the flow in the series for easy understanding, but I failed :-(
Actually you did not. I just did not agree with some implementation
details. And the changes need beter documentation.
> With these patches, new code looks differently compared to original code.
> So I feel instead of providing incremental patches- I should provide
> 1. basic mkimge framework patch,
> 2. mkimage: add: uimage support patch,
> 3. mkimage: add: fit image support patch,
Um... these three must never be split. I mean, we should not add any
patch that breaks the (existing) mkimage support.
> 4. mkimage: add: Kirkwood boot image support patch.
> I will do this in my next post.
> I hope you will like it.
> If you have any inputs in this regard or you think this is bad plan, pls kindly let me know.
I'm not sure if this will be an improvement. I guess it will make it
even harder to understand the changes.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Infidels in all ages have battled for the rights of man, and have at
all times been the fearless advocates of liberty and justice."
- Robert Green Ingersoll
More information about the U-Boot
mailing list