[U-Boot] [PATCH 1/1] Adding Configuration option for TQM5200S Board on Goetting

[Wolfgang Denk]

Dear Detlev Zundel,

In message <m2iqhaed2s.fsf at ohwell.denx.de> you wrote:
> 
> >> @@ -808,6 +809,12 @@ TQM5200_STK100_config:	unconfig
> >>  	@[ -z "$(findstring HIGHBOOT,$@)" ] || \
> >>  		{ echo "TEXT_BASE = 0xFFF00000" >$(obj)board/tqm5200/config.tmp ; \
> >>  		}
> >> +	@[ -z "$(findstring HG43630,$@)" ] || \
> >> +		{ echo "#define CONFIG_HG43630"	>>$(obj)include/config.h ; \
> >> +		  echo "#define CONFIG_TQM5200S"	>>$(obj)include/config.h ; \
> >> +		  echo "#define CONFIG_TQM5200_B"	>>$(obj)include/config.h ; \
> >> +		  $(XECHO) "... TQM5200S on Goetting HG43630 Board" ; \
> >> +		}
> >>  	@$(MKCONFIG) -n $@ -a TQM5200 ppc mpc5xxx tqm5200 tqc
> >
> > Please don't add board specific configuration to the top level
> > Makefile; do thi sin your board config file instead.
> 
> Can you explain what you want to see here?  The board is based on a
> tqm5200 module, so he actually does not want to copy his own config
> file.  Personally I think this solution to be ok, can you explain what
> you don't like about it?

Board specific configurations (liek #defining CONFIG_TQM5200S and
CONFIG_TQM5200_B when CONFIG_HG43630 is set) should not be done in the
Makefile, but in the board config file instead.

Actually I want to get rid of most of such longish scripting in the
Makefile, and I started rejecting all patches that add such stuff.

An example how to solve this can be found here:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65499

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If all the Chinese simultaneously jumped into the Pacific  off  a  10
foot platform erected 10 feet off their coast, it would cause a tidal
wave that would destroy everything in this country west of Nebraska.