[U-Boot] [PATCH v2 1/8] tools: mkimage : bugfix returns correct value for list command

Wolfgang Denk wd at denx.de
Mon Aug 10 11:06:58 CEST 2009


Dear Prafulla Wadaskar,

In message <1249910377-17974-1-git-send-email-prafulla at marvell.com> you wrote:
> List command always return "EXIT_SUCCESS" even in case of
> failure by any means.
> 
> This patch return 0 if list command is sucessful,
> returns negative value reported by check_header functions
> 
> Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> ---
> Change log:
> v2: added code rewritten to look it better as per review feedback for v1
> 
>  tools/mkimage.c |   26 ++++++++++++++------------
>  1 files changed, 14 insertions(+), 12 deletions(-)

Thanks. To make some (visible) progress I decided to check in patches
where we have full agreement into the (new) "mkimage" branch. This way
we can gradually reduce the amount of stuff we need to discuss.

This patch has been applied to the "mkimage" branch. Thanks.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Fools ignore complexity. Pragmatists suffer it. Some  can  avoid  it.
Geniuses remove it.
     - Perlis's Programming Proverb #58, SIGPLAN Notices, Sept.  1982


More information about the U-Boot mailing list