[U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed Aug 12 23:03:39 CEST 2009


On 20:50 Wed 12 Aug     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <1250023747-20224-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > ---
> >  include/net.h |    1 +
> >  net/eth.c     |   17 +++++------------
> >  2 files changed, 6 insertions(+), 12 deletions(-)
> 
> What exactly is the problem you are addressing with this patch?
> 
> Please provide a commit message that explains what is going on, and
> what is being changed or fixed.
simple it impossible to known what will be your device index in the driver
specially when you have 2 or more drivers instance once or more
so you can not update the mac addres in the env if you want to do it
as we do on smc91111 as we can not known eth%daddr you are
which allow us the avoid to read the eeprom every time we want to use the eth

Best Regards,
J.


More information about the U-Boot mailing list