[U-Boot] [PATCH] OMAP3 Move cache routines to cache.S

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed Aug 12 23:13:16 CEST 2009


On 10:42 Wed 12 Aug     , Tom Rix wrote:
> v7_flush_dcache_all, because it depends on omap ROM code is not
> generic.  Rename the function to 'invalidate_dcache' and move it
> to the omap cpu directory.
> 
> Collect the other omap cache routines l2_cache_enable and
> l2_cache_disable with invalide_dcache into cache.S.  This
> means removing the old cache.c file that contained l2_cache_enable
> and l2_cache_disable.
> 
> The conversion from cache.c to cache.S was done most through
> disassembling the uboot binary.  The only significant change was
> to change the comparision for the return of get_cpu_rev from
> 
>    cmp	r0, #0
>    beq	earlier_than_label
> 
> Which was lost information to
> 
>    cmp	r0, #CPU_3XX_ES20
>    blt	earlier_than_label
> 
> The paths through the enable routine were verified by
> adding an infinite loop and seeing the hang.  Then
> removing the infinite loop and seeing it continue.
> 
> The disable routine is similar enough that it was not
> tested with this method.
> 
> Run tested by cold booting from nand on beagle and zoom1.
> Compile tested on MAKEALL arm.
for the l2 cache ACK
for the invalidate cache NACK

we do not need to call the rom code as the armv7 flush cache work fine
on omap3 and duplicate armv7 code with really few code (non needed) no

Best Regards,
J.


More information about the U-Boot mailing list