[U-Boot] [PATCH 3/8]: Define test_and_set/clear_bit for ARM

Simon Kagstrom simon.kagstrom at netinsight.net
Mon Aug 17 16:43:23 CEST 2009


On Sun, 19 Jul 2009 11:47:13 +0200
Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> wrote:

> On 15:58 Tue 07 Jul     , Simon Kagstrom wrote:
> > Signed-off-by: Simon Kagstrom <simon.kagstrom at netinsight.net>
> > ---
> >  include/asm-arm/bitops.h |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> NACK
> 
> the test_and_set_bit and co must be endianless specific
> which is not the case here

OK. Anyway, the bitops implementation is a bit messy (which I noted
when trying to get ubifs working on arm - hence these patches). Maybe
an idea could be to bring in the Linux asm-generic/bitops/* instead and
remove the architecture-specific versions?

// Simon


More information about the U-Boot mailing list