[U-Boot] [PATCH v2 1/2] tools: mkimage: Fixed build warnings

Wolfgang Denk wd at denx.de
Tue Aug 18 14:22:23 CEST 2009


Dear Prafulla Wadaskar,

In message <1250380700-15636-1-git-send-email-prafulla at marvell.com> you wrote:
> uninitialized retval variable warning fixed
> crc32 APIs moved to crc.h (newly added) and build warnings fixed
> some indentation tabs fixed
> 
> Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> ---
> Change log:
> v2: updated as per review feedback for v1
> 
>  include/common.h     |    4 +---
>  include/u-boot/crc.h |   33 +++++++++++++++++++++++++++++++++
>  tools/mkimage.c      |   20 +++++++++++---------
>  3 files changed, 45 insertions(+), 12 deletions(-)
>  create mode 100644 include/u-boot/crc.h

Applied to "mkimage" branch.

I decided to omit the tab cleanup, and used "uchar" instead of
"unsigned char" so no reformatting due to growing line length was
needed.  This way the changes are (IMHO) better visible.

Hope this is OK with you.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Build a system that even a fool can use and only a fool will want  to
use it.


More information about the U-Boot mailing list