[U-Boot] [PATCH v2 1/2] tools: mkimage: Fixed build warnings

[Prafulla Wadaskar]

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de] 
> Sent: Tuesday, August 18, 2009 6:23 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH v2 1/2] tools: mkimage: Fixed 
> build warnings
> 
> Dear Prafulla,
> 
> In message <20090818122223.73095833DBD2 at gemini.denx.de> I wrote:
> > 
> > In message 
> <1250380700-15636-1-git-send-email-prafulla at marvell.com> you wrote:
> > > uninitialized retval variable warning fixed
> > > crc32 APIs moved to crc.h (newly added) and build warnings fixed
> > > some indentation tabs fixed
> > > 
> > > Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> > > ---
> > > Change log:
> > > v2: updated as per review feedback for v1
> > > 
> > >  include/common.h     |    4 +---
> > >  include/u-boot/crc.h |   33 +++++++++++++++++++++++++++++++++
> > >  tools/mkimage.c      |   20 +++++++++++---------
> > >  3 files changed, 45 insertions(+), 12 deletions(-)
> > >  create mode 100644 include/u-boot/crc.h
> > 
> > Applied to "mkimage" branch.
> > 
> > I decided to omit the tab cleanup, and used "uchar" instead of
> > "unsigned char" so no reformatting due to growing line length was
> > needed.  This way the changes are (IMHO) better visible.
> 
> ...what a stupid idea. I didn't consider that "uchar" might not be
> defined in standard compile environments. Undone.
> 
> I applied your original patch now, just with minimal indentation
> changes.
:-D Thanks....
Regards..
Prafulla . .

> 
> Sorry for the confusion.
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> I usually tell my classes "if you are using @ and [] together in this
> class, you will almost certainly NOT get what you want. That's  going
> down  the wrong tunnel. There's no cheese at the end of that tunnel."
>          -- Randal L. Schwartz in <8czptuomey.fsf at gadget.cscaper.com>
>