[U-Boot] [PATCH] arm:kirkwood Wait for the link to come up on kirkwood network init
Ben Warren
biggerbadderben at gmail.com
Wed Aug 19 21:29:12 CEST 2009
Wolfgang Denk wrote:
> Dear Ben Warren,
>
>
<snip>
>
>>> + /* Wait up to 5s for the link status */
>>> + for (i = 0; i < 5; i++) {
>>> + u16 phyadr;
>>>
>>>
>> Please put this variable declaration outside of the 'for' loop
>>
>
> Why? If it's only used in this block it's actually a good thing to
> restrict it to this scope.
>
>
It seems your coding standards have changed, which everybody knows is
impossible. Where's you put the old Wolfgang, doppleganger? :)
> Best regards,
>
> Wolfgang Denk
>
>
regards,
Ben
More information about the U-Boot
mailing list