[U-Boot] [PATCH] AT91: Add support for blue_LED_* and add coloured_LED_init to at91/led.c

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Thu Aug 20 02:00:45 CEST 2009

On 10:49 Tue 18 Aug     , Albin Tonnerre wrote:
> On Tue, Aug 18, 2009 at 12:51:48AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote :
> > no please take a look on the other LED thread
> Would you please provide a pointer to this thread ? THe only one remotely
> related I can find is
> http://lists.denx.de/pipermail/u-boot/2009-May/052160.html, and you did not
> participate in this one ...
I've as I'm the one who ask Daniel Gorsulowski to base his new code (this patch)
against Ulf precedent patch and as other people have done the same comment as I will do
no need to repeat it
> > I want to hape coloured-LED api and numbered led handle by the same api
> > with the less size impact
> When you have this same API, you'll still need code to turn LEDs on and off, and
> you'll still have to beat the LED code out of cards-specific code because it
> really ought to be in a common file. My patch does exactly that, does *not*
> impact size, and is an actual step towards whatever you plan next. I'd prefer if
> you were rejecting this on actual, justified grounds.
your patch does not do it
1) you force the init led to be common which must be board specific as every one can do it
how he want

2) you do brake all at91 boards too

3) as already said multiple time we need to cleanup it and stop adding new color support
for eachi board or arch specialy when no board use it

Best Regards,

More information about the U-Boot mailing list