[U-Boot] [PATCH] driver/fsl_pci: Added fsl_pci_init_port function to initialize a single PCIe port.

Wolfgang Denk wd at denx.de
Thu Aug 20 17:12:09 CEST 2009


Dear Poonam Aggrwal,

In message <1250775038-20372-1-git-send-email-poonam.aggrwal at freescale.com> you wrote:
> *  Added a generic function fsl_pci_init_port in drivers/pci/fsl_pci.c
>    to initialize a PCIe port.
> *  fsl_pci_init_port can be called from board specific pcie initialization
>    routine, per-port. 
> *  This will reduce the code redundancy in the most of the Freescale board
>    specific PCIe inits.
> 
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal at freescale.com>
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> ---

NAK.

I see just dead code added, without any users.

If this gets used somewhere, this should be visible in the patch, and
lead to code removed somewhere?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You cannot propel yourself forward by patting yourself on the back.


More information about the U-Boot mailing list