[U-Boot] [PATCH v2 1/4]: Move __set/clear_bit from ubifs.h to bitops.h

Simon Kagstrom simon.kagstrom at netinsight.net
Fri Aug 21 08:05:47 CEST 2009


On Thu, 20 Aug 2009 13:44:35 -0400
Mike Frysinger <vapier at gentoo.org> wrote:

> On Thursday 20 August 2009 04:52:50 Simon Kagstrom wrote:
> > --- a/include/asm-sh/bitops.h
> > +++ b/include/asm-sh/bitops.h
> > @@ -146,6 +146,11 @@ static inline int ffs (int x)
> >  	}
> >  	return r;
> >  }
> > +
> > +#define __set_bit(nr, addr) generic_set_bit(nr, addr)
> > +
> > +#define __clear_bit(nr, addr) generic_clear_bit(nr, addr)
> 
> this is just silly to put into every arch header.  why not do in the common 
> code:
> #ifndef __set_bit
> # define __set_bit generice_set_bit
> #endif

It's a function (static inline) in some architectures.

// Simon



More information about the U-Boot mailing list