[U-Boot] [PATCH v2 1/4]: Move __set/clear_bit from ubifs.h to bitops.h

Simon Kagstrom simon.kagstrom at netinsight.net
Fri Aug 21 09:03:39 CEST 2009


On Fri, 21 Aug 2009 02:29:30 -0400
Mike Frysinger <vapier at gentoo.org> wrote:

> > > this is just silly to put into every arch header.  why not do in the
> > > common code:
> > > #ifndef __set_bit
> > > # define __set_bit generice_set_bit
> > > #endif
> >
> > It's a function (static inline) in some architectures.
> 
> add the obvious #define i already posted in a later e-mail.  it makes a lot 
> more sense for the non-common behavior of providing a custom implementation to 
> add one more line per func than to try and update (and keep up-to-date) every 
> arch using the common code.

Yep, I saw your mail too late. I'll rework the patch series and resubmit.

// Simon



More information about the U-Boot mailing list