[U-Boot] [RFC PATCH 2/3] stdio: pass the current device to the driver

Wolfgang Denk wd at denx.de
Sun Aug 23 20:56:30 CEST 2009


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1251034019-10787-2-git-send-email-plagnioj at jcrosoft.com> you wrote:
> to allow it to have base address and other information to simplify
> the implementation and avoid workarround as done for ns16550 on the omap3 zoom
> or ppc4xx as example

Can you please explain what you mean?

Sorry, but I do not understand your commit message. Please use
complete sentences.

If I understood your patch 1/3 correctly, you introduces a current
device; if this is correct, then why do we need to add allt he
additional function arguments?

Isn't this only adding to the memory footprint?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is practically impossible to teach good programming style to  stu-
dents that have had prior exposure to BASIC: as potential programmers
they are mentally mutilated beyond hope of regeneration.   - Dijkstra


More information about the U-Boot mailing list