[U-Boot] [PATCH] Remove deprecated 'autoscr' command

[Peter Tyser]

Hi Wolfgang,

> > There was a fair amount of grey area as far as environment variable naming
> > for those variables that used to refernce autoscr.
> 
> Why actually?

I guess because we don't see eye-to-eye:)

> > I tended to lean toward using "script" in the variable name as I thought
> > that was a lot more descriptive than "source", which could mean lots of
> > different things.  eg I migrated autoscr_addr to script_addr instead
> > of source_addr.
> > 
> > I also figured the "autoscript" and "autoscript_uname" variables
> > were more descriptive than "autosource" and "autosource_uname", so they
> > were left alone.
> 
> I disagree here. "autoscript" has not much (if any) meaning when it
> comes to executing shell scripts (and this is what we are talking
> about there). I am not aware of a single man page in any of the many
> Unix flavours using this term. [OTOH, it is the name of an existing
> company and as such eventually a protected trade mark, at least in
> some parts of the world.]

I agree the term "autoscript" is non-standard, but what would be a
better name for relating to a scipt that is automatically executed?  The
description of the current autoscript variable is:

  autoscript	- if set to "yes" commands like "loadb", "loady",
		  "bootp", "tftpb", "rarpboot" and "nfs" will attempt
		  to automatically run script images (by internally
		  calling "source").

so if "autoscript" is set, a script is automatically ran.  This name
makes some sense to me and I couldn't think of a better one.  Its name
is also inline with the "autoload" and "autostart" variables.  I think
"autosource" is going to confuse a lot of people and is less descriptive
than the current "autoscript".

> > If others (especially board maintainers affected) have a strong opinion
> > about environment variable naming let me know.
> 
> I do. I want to get rid of references to "autoscr" / "autoscript".

Would you prefer to keep the functionality of the "autoscript" variable
but with a different name, or remove that functionality altogether?  Or
are you referring to the references of "autoscript" in the
board/matrix_vision/mvbc_p/mvbc_p_autoscript and
board/matrix_vision/mvblm7/mvblm7_autoscript files?

A little off topic, but I'd personally love to get rid of the
autoscript/autoscript_uname/autostart/autoload variables and have people
explicitly use the commands they need.  For example, the dhcp command
would only set some environment variable values, then tftp/nfs would
have to be called, followed by the appropriate boot command.  Right now,
the dhcp command behave in a number of different ways depending on the
values of the auto* variables mentioned above.  Same with tftp, loadb,
etc.

Best,
Peter