[U-Boot] [PATCH v4] use common code for Matrix Vision boards

André Schwarz andre.schwarz at matrix-vision.de
Thu Aug 27 10:54:49 CEST 2009


On Wed, 2009-08-26 at 21:46 +0200, Wolfgang Denk wrote:
> Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,
> 
> In message <1250682092.22118.8.camel at swa-m460> you wrote:
> > clean up existing boards (mvBC-P/MPC5200 and mvBL-M7/MPC8343)
> > by using common code.
> > 
> > 
> > Signed-off-by: Andr=C3=A9 Schwarz <andre.schwarz at matrix-vision.de>
> > ---
> > 
> > Wolfgang,
> > this is my current diff against your latest master repository - I'm
> > unable to split it anymore.
> > Unfortunately the e1000 is currently not working on the mvBC-P but this
> > is due to changes in drivers/net/e1000.c ... using the last released
> > version is working fine. Will contact the maintainer to fix it.
> > Hopefully you'll nevertheless apply this patch so that everybody using
> > the boards can get up-to-date again.
> 
> Sorry for the late reply.
> 
> ...
> > diff --git a/board/matrix_vision/mvbc_p/mvbc_p_autoscript
> > b/board/matrix_vision/mvbc_p/mvbc_p_autoscript
> > index 5cee6c5..1102354 100644
> > --- a/board/matrix_vision/mvbc_p/mvbc_p_autoscript
> > +++ b/board/matrix_vision/mvbc_p/mvbc_p_autoscript
> > @@ -5,7 +5,7 @@ setenv bootdtb bootm \${kernel_boot} \
> > ${mv_initrd_addr_ram} \${mv_dtb_addr_ram}
> >  setenv ramkernel setenv kernel_boot \${loadaddr}
> >  setenv flashkernel setenv kernel_boot \${mv_kernel_addr}
> >  setenv cpird cp \${mv_initrd_addr} \${mv_initrd_addr_ram} \
> > ${mv_initrd_length}
> > -setenv bootfromflash run flashkernel cpird ramparam addcons e1000para
> > bootdtb
> > +setenv bootfromflash run flashkernel cpird ramparam addcons e1000para
> > addprofile bootdtb
> 
> ^^^^^^^^^^^^^^^^
> Patch is linewrapped here and elsewhere and thus cannot be applied.

bloody eMail client :-(
The patch file definitely is *not* linewrapped.

> 
> Please fix and resubmit. Make sure to use git-send-email for sending.

I'll set up git-send-email and try to send the very same patch file.
Hopefully it will work as expected - sorry for the mess ...


Regards,
André

> 
> Thanks.
> 
> Best regards,
> 
> Wolfgang Denk
> 



MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich


More information about the U-Boot mailing list