[U-Boot] [PATCH] add Matrix Vision specific dir for common code.

André Schwarz andre.schwarz at matrix-vision.de
Mon Aug 31 14:41:50 CEST 2009


Wolfgang,

On Mon, 2009-08-31 at 14:07 +0200, Wolfgang Denk wrote:
> Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,
> 
> In message <1251712526.4189.25.camel at swa-m460> you wrote:
> >
> > ok - Signed-off-by is missing although my .gitconfig has "signoff =
> > true" set in [format] section ... looks like I need -s arg at git
> > format-patch. Any hints about this ?
> 
> The Signed-off-by: does not get added when exporting the commit as a
> patch, but when committing the changes, i. e. it is part of the commit
> message, not added later.

But giving "-s" to git format-patch actually adds the Singed-off-by: ...

Anyway ... I'll do as you suggest, i.e. add it to the commit message.

> 
> > I also couldn't figure out how to send a *single* mail for a single
> > patch, i.e. without this initial stuff. IMHO this is only needed for a
> > patch series.
> 
> What do you mean by "initial stuff" ?

git send-mail always creates two or more mails. The first one is
unnecessary for a single patch, i.e. not a patch series.

> 
> > Is there anything else you want me to fix for this patch before I
> > resubmit it ?
> 
> Please provide a usable commit message (if needed, use "git commit
> --amend", eventually as part of a "git rebase -i", to fix the commit
> message in your repository) and make sure it contains a Signed-off-by:
> line.

ah - excellent. That's what I've been looking for. Thank you.

Regards,
André

> 
> 
> Best regards,
> 
> Wolfgang Denk
> 



MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich


More information about the U-Boot mailing list