[U-Boot] [PATCH] add block write function to spartan3 slave serial load

Wolfgang Denk wd at denx.de
Fri Dec 4 11:16:52 CET 2009


Dear w.wegner at astro-kom.de,

In message <4B18E5C5.22102.97D23 at w.wegner.astro-kom.de> you wrote:
>
> > Where is this block write function being implemented?
> > 
> > I don't see it anywhere in the patch, nor any code that actually uses
> > it?
> 
> sorry, my wording was probably wrong.
> This current patch only adds the framework in the FPGA code needed
> to use such a block write function.
> 
> Like all FPGA load functions, the function itself is located in my board-
> specific code (which is not yet submitted because I have to clean up
> some coding style issues in one of the files and it depends on the other
> patches I sent). My understanding was that such framework changes
> should always be sent as seperate patches and the (new) board that
> uses it as a different patch.

Yes, but we don't add one without the other.  There have been too many
cases where people asked for fancy features for specific boards that
were out-of-tree ports without any attempts to get merged, so we now
always wait for actual use cases. [I do not want to suggest that I
consider yours as one of these situations, but the effect is the
same.]

I put this patch on hold until you submit code that requires / uses
it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can love it, change it, or leave it.    There is NO other option.
But do not complain - it is your own choice...                  -- wd


More information about the U-Boot mailing list