[U-Boot] missing gunzip prototype (was: [RFC PATCH] add ability to handle compressed images to imxtract)
w.wegner at astro-kom.de
w.wegner at astro-kom.de
Fri Dec 4 13:41:01 CET 2009
Dear Wolfgang Denk,
On 2 Dec 2009 at 22:43, Wolfgang Denk wrote:
> Dear Wolfgang Wegner,
>
> In message <1256916625-30792-1-git-send-email-w.wegner at astro-kom.de> you wrote:
> > imxtract currently can not handle compressed images. This patch adds
> > handling for bzip2 and zip compression. In both cases, a destination
> > address has to be specified for extraction.
> >
> > Signed-off-by: Wolfgang Wegner <w.wegner at astro-kom.de>
> ...
>
> > +/* there is no prototype in zlib.h */
> > +int gunzip (void *, int, unsigned char *, unsigned long *);
>
> Then we should add it there, once.
I have to admit I am not sure if there might be a reason why there is no prototype
nor if it would belong in zlib.h at all (IIRC it was there ages ago, but then re-structured,
so probably even my comment is out-dated).
The implementation is in lib_generic/gunzip.c, and it is used by 19 other files.
I could add it to a header but have (at least) two problems with it:
- I do not know which header would be appropriate (generate a new one like
e.g. lib_generic/addr_map.c -> include/addr_map.h?)
- I can not test all the boards currently using it, as they belong to completely
different architectures
Any comments welcome if/how I should proceed here.
[...]
Addressing the other issues in the meantime... ;-)
Best regards,
Wolfgang
More information about the U-Boot
mailing list