[U-Boot] [PATCH, REGRESSION] mpc83xx: provide option to set LCRR early

Kim Phillips kim.phillips at freescale.com
Sat Dec 5 03:30:59 CET 2009


On Fri, 20 Nov 2009 12:42:43 +0100
Peter Korsgaard <jacmet at sunsite.dk> wrote:

> E.G. on a 8347 board a bootup time increase of ~600ms has been observed:

heh, even more on an 8313!  Thanks for this - I hadn't realized the
difference was so large (or neglected it since the move to init_r was
done at the last moment).

> Fix it by introducing CONFIG_SYS_LCRR_EARLY, and set LCRR in cpu_init_f
> instead of in cpu_init_r if set.

instead of introducing the new CONFIG_SYS_LCRR_EARLY, shouldn't we
check for something like:

!defined(CONFIG_NAND_SPL) && !defined(CONFIG_SYS_RAMBOOT)

?

> +++ b/cpu/mpc83xx/cpu_init.c
> @@ -171,6 +171,30 @@ void cpu_init_f (volatile immap_t * im)
>  		(CONFIG_SYS_SCCR_SATACM << SCCR_SATACM_SHIFT) |
>  #endif
>  		0;
> +#ifdef CONFIG_SYS_LCRR_EARLY

btw, this generates:

cpu_init.c: In function 'cpu_init_r':
cpu_init.c:367: warning: unused variable 'im'

Kim


More information about the U-Boot mailing list