[U-Boot] [PATCH] MAKEALL: Fix return value
Wolfgang Denk
wd at denx.de
Sun Dec 6 17:43:11 CET 2009
Dear Peter Tyser,
In message <1260083374-11002-1-git-send-email-ptyser at xes-inc.com> you wrote:
> Previously MAKEALL would always return a value of 0, even if 1 or more
> boards did not compile.
>
> This change causes MAKEALL to return the number of board's which did not
> compile. 0 indicates success, 2 indicates 2 board did not compile, etc.
NAK. This is non-standard behaviour. Commands usually return 0 for OK
or 1 in case of errors. Any higher numbers (especially when exceeding
the magical limit of 127) may cause confusion to callers.
And as Mike pointed out, above 255 it simply breaks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Alles Gescheite ist schon gedacht worden, man muß nur versuchen,
es noch einmal zu denken. -- Goethe, Maximen und Reflexionen
More information about the U-Boot
mailing list