[U-Boot] [PATCH] Stop stack clobbering in microblaze-generic.

Michal Simek monstr at monstr.eu
Tue Dec 8 09:28:12 CET 2009


Hi Graeme,

Graeme Smecher wrote:
> From: Graeme Smecher <gsmecher at tonka.atlantic.home>
> 
> A typo caused the stack and malloc regions to overlap, which prevented
> mem_malloc_init() from returning. This commit makes the memory layout match
> the example described in include/configs/microblaze-generic.h

I added your Sign-off-by line and all microblaze patches should have 
"microblaze:" prefix in subject. I fixed these things and your patch is 
in microblaze repo.

Thanks,
Michal

> ---
>  include/configs/microblaze-generic.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h
> index b486c77..9b1569a 100644
> --- a/include/configs/microblaze-generic.h
> +++ b/include/configs/microblaze-generic.h
> @@ -146,7 +146,7 @@
>  #define	CONFIG_SYS_MALLOC_BASE		(CONFIG_SYS_MONITOR_BASE - CONFIG_SYS_MALLOC_LEN)
>  
>  /* stack */
> -#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MONITOR_BASE
> +#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MALLOC_BASE
>  
>  /*#define	RAMENV */
>  #define	FLASH


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian


More information about the U-Boot mailing list