[U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

Wolfgang Denk wd at denx.de
Wed Dec 16 23:15:20 CET 2009


Dear "Premi, Sanjeev",

In message <B85A65D85D7EB246BE421B3FB0FBB59301E157AAE8 at dbde02.ent.ti.com> you wrote:
> 
> Also, I don't believe there is any complexity added as
> the contents of register are being read and saved in a
> global variable for use later.

Global variables are a bad thing if there is not really a good reason
to hav ethem. Here it makes no sense to me. Execution time seems
uncritical, and there is no kind of hardware wear involved with
readin the registers, so like Tom I don't see a reason for this
"optimization".

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How does a project get to be a year late?      ... One day at a time.


More information about the U-Boot mailing list