[U-Boot] [PATCH 07/25] Blackfin: do not require CONFIG_BAUDRATE

Wolfgang Denk wd at denx.de
Thu Dec 17 22:32:38 CET 2009


Dear Mike Frysinger,

In message <1261017850-22802-8-git-send-email-vapier at gentoo.org> you wrote:
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> ---
>  cpu/blackfin/initcode.c |    3 +++
>  lib_blackfin/board.c    |    2 ++
>  2 files changed, 5 insertions(+), 0 deletions(-)
...
>  static int init_baudrate(void)
>  {
> +#ifdef CONFIG_BAUDRATE
>  	char baudrate[15];
>  	int i = getenv_r("baudrate", baudrate, sizeof(baudrate));
>  	gd->bd->bi_baudrate = gd->baudrate = (i > 0)
>  	    ? simple_strtoul(baudrate, NULL, 10)
>  	    : CONFIG_BAUDRATE;
> +#endif
>  	return 0;
>  }

Out of curiosity: what do these boards do when CONFIG_BAUDRATE is not
defined?

It seems yo me you add a new, additional meaning to the
CONFIG_BAUDRATE option here. This should be documented (at least in
the README).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Time is fluid ... like a river with currents, eddies, backwash.
	-- Spock, "The City on the Edge of Forever", stardate 3134.0


More information about the U-Boot mailing list