[U-Boot] [PATCH 15/25] Blackfin: use new bfin read/write mmr helper funcs

[Wolfgang Denk]

Dear Mike Frysinger,

In message <1261017850-22802-16-git-send-email-vapier at gentoo.org> you wrote:
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> ---
>  cpu/blackfin/initcode.c               |   10 ++--
>  cpu/blackfin/interrupts.c             |   12 ++--
>  cpu/blackfin/serial.c                 |   20 ++---
>  cpu/blackfin/serial.h                 |  119 +++++++++++++++++---------------
>  include/asm-blackfin/blackfin_local.h |    2 +-
>  5 files changed, 83 insertions(+), 80 deletions(-)
...
>  /* When debugging is disabled, we only care about the DR bit, so if other
>   * bits get set/cleared, we don't really care since we don't read them
>   * anyways (and thus anomaly 05000099 is irrelevant).
>   */
> -static inline uint16_t uart_lsr_read(void) { return *pUART_LSR; }
> -static inline void uart_lsr_clear(void) { *pUART_LSR = -1; }
> +static uint16_t uart_lsr_read(void) { return bfin_read16(&pUART->lsr); }
> +static void uart_lsr_clear(void) { bfin_write16(&pUART->lsr, bfin_read16(&pUART->lsr) | -1); }

Line too long.

...
> +# define ACCESS_LATCH()    bfin_write16(&pUART->lcr, bfin_read16(&pUART->lcr) | DLAB)
> +# define ACCESS_PORT_IER() bfin_write16(&pUART->lcr, bfin_read16(&pUART->lcr) & ~DLAB)

Ditto. Please fix globally.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human race is faced with a cruel choice: work  or  daytime  tele-
vision.