[U-Boot] [PATCH 08/25] Blackfin: kill off useless initdram() usage

Wolfgang Denk wd at denx.de
Thu Dec 17 23:48:48 CET 2009


Dear Mike Frysinger,

In message <200912171723.51435.vapier at gentoo.org> you wrote:
>
> > Would it not make sense to start using get_ram_size(), too?
>
> i havent heard of this function before.  looking through the tree, it seems

Seems you have ignored a lot of messages on this list ;-)

> like this is an optional board-specific function that probes external memory 
> sizes by reading/writing to it.

Right, with at least two purposes: detecting memroy errors, and
determining the available memory size.

> on a Blackfin system, this is a pretty big waste.  memory must always be 

Waste in terms of ... ?

> mapped starting at address 0 which means once the highest address is 
> validated, things can return.  ignoring that, the Blackfin port has no 
> relocation support, so the link time addresses are fixed.

The memory test alone is a pretty good reason to add this. And don;t
you have boards with multiple configurations / different RAM sizes
where auto-sizing would be useful?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Worlds are conquered, galaxies destroyed -- but a woman is  always  a
woman.
	-- Kirk, "Conscience of the King", stardate unknown


More information about the U-Boot mailing list