[U-Boot] [PATCH 7/9] SPEAr310 SoC support added

[Vipin Kumar]

Dear Wolfgang,

>>
>> Signed-off-by: Vipin <vipin.kumar at st.com>
>> ---
>>  MAKEALL                             |    1 +
>>  Makefile                            |    3 +
>>  board/spear/spear310/Makefile       |   52 +++++
>>  board/spear/spear310/config.mk      |   42 ++++
>>  board/spear/spear310/spr310_board.c |   58 ++++++
>>  include/configs/spear310.h          |  353 +++++++++++++++++++++++++++++++++++
>
> The commit message seems wrong. You just add a new board, not a new
> SoC.

SPEAr310 is a new SoC but it has a lot in common with SPEAr300
Offcourse, since only the common IP's are supported in uboot, there
is no new driver required for SPEAr310.

>> diff --git a/board/spear/spear310/config.mk b/board/spear/spear310/config.mk
>> new file mode 100755
>> index 0000000..8b7aa05
>> --- /dev/null
>> +++ b/board/spear/spear310/config.mk
> ...
>> +ifeq ($(CONSOLE),USB)
>> +PLATFORM_RELFLAGS += -DCONFIG_SPEAR_USBTTY
>> +endif
>> +
>
> No trailing empty lines, please.

Ok. Trailing empty lines removed globally

>> +int board_nand_init(struct nand_chip *nand)
>> +{
>> +     struct misc_regs *const misc_regs_p =
>> +             (struct misc_regs *)CONFIG_SPEAR_MISCBASE;
>> +
>> +     if (((readl(&misc_regs_p->auto_cfg_reg) & MISC_SOCCFGMSK) ==
>> +                             MISC_SOCCFG30) ||
>> +        ((readl(&misc_regs_p->auto_cfg_reg) & MISC_SOCCFGMSK) ==
>> +                             MISC_SOCCFG31)) {
>> +
>> +             return spear_nand_init(nand);
>> +     } else {
>> +             return -1;
>> +     }
>
> No else, unindent the "return -1;".

Ok. else removed and return -1 unindented

>> +/*
>> + * Ethernet MAC driver configuration
>> + */
>> +/* #define CONFIG_SPEAR_SMII */
>> +/* #define CONFIG_SPEARMAC */
>> +/* #define CONFIG_ETHAUTONEG */
>> +/* #define CONFIG_ETHDEBUG */
>
> Don't add dead code (fix globally).

Fixed globally

>> +
>> +#define CONFIG_SYS_SERIAL1                      0xB2000000
>> +#define CONFIG_SYS_SERIAL2                      0xB2080000
>> +#define CONFIG_SYS_SERIAL3                      0xB2100000
>> +#define CONFIG_SYS_SERIAL4                      0xB2180000
>> +#define CONFIG_SYS_SERIAL5                      0xB2200000
>> +#define CONFIG_PL01x_PORTS                      { (void *)CONFIG_SYS_SERIAL0,  \
>> +                                             (void *)CONFIG_SYS_SERIAL1,    \
>> +                                             (void *)CONFIG_SYS_SERIAL2,    \
>> +                                             (void *)CONFIG_SYS_SERIAL3,    \
>> +                                             (void *)CONFIG_SYS_SERIAL4,    \
>> +                                             (void *)CONFIG_SYS_SERIAL5}
>
> Indentation / avertical alignment by TABs, please. [Globally.]

Changed to use tabs for indenting and vertical alignment

>> +#define CONFIG_BOOTARGS                              "console=ttyS0 mem=128M "  \
> ...
>> +#define CONFIG_ENV_ADDR                              (CONFIG_SYS_MONITOR_BASE + \
>
> etc.: Lines too long.

Long lines curtailed globally

Best Regards
Vipin