[U-Boot] [PATCH] bdinfo: Don't print IP or MAC addresses on boards without network support

[Wolfgang Denk]

Dear Stefan Roese,

In message <1261547803-11526-1-git-send-email-sr at denx.de> you wrote:
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>  common/cmd_bdinfo.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)

I don't consider this a good idea.

Please keep in mind that the "bdinfo" command is (or rather was)
mainly intended for (old) PPC boards that pass hardware information to
the Linux kernel by means of struct bd_info.

Even if you comment out printing of network related fields, these are
still being passed to the kernel on such systems, so we should rather

1) make sure they are properly initialized in all cases (with
   well-defined dummy-values if no other values are present),
2) keep printing all fields actually passed to the Linux kernel, and
   in the right order, as was the intention of this command.

Also, I disagree with this change as you are exporting U-Boot
settings to Linux, which is IMHO not always correct. There might be
cases where you don't have network support in U-Boot, but the Linux
kernel might have it, and you want to pass network configuration
parameters even if they are unused in U-Boot (consider for example
the case where U-Boot has no network driver yet).


Thinking about this again, I tend to reject _both_ your patches.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anyone can count the seeds in an apple.
No one can count the apples in a seed.