[U-Boot] [PATCH] TI DaVinci: Driver for the davinci SPI controller

[Sudhakar Rajashekhara]

Hi,

On Thu, Dec 24, 2009 at 07:04:18, Mike Frysinger wrote:
> On Wednesday 23 December 2009 02:44:36 Sudhakar Rajashekhara wrote:
> > --- a/drivers/spi/Makefile
> > +++ b/drivers/spi/Makefile
> > @@ -34,6 +34,7 @@ COBJS-$(CONFIG_MPC52XX_SPI) += mpc52xx_spi.o
> >  COBJS-$(CONFIG_MPC8XXX_SPI) += mpc8xxx_spi.o
> >  COBJS-$(CONFIG_MXC_SPI) += mxc_spi.o
> >  COBJS-$(CONFIG_SOFT_SPI) += soft_spi.o
> > +COBJS-$(CONFIG_DAVINCI_SPI) += davinci_spi.o
> 
> this is a sorted list
> 

Will fix it. Thanks for pointing it out.

> > --- /dev/null
> > +++ b/drivers/spi/davinci_spi.h
> > @@ -0,0 +1,84 @@
> > +/*
> > + * Register definitions for the DaVinci SPI Controller  */
> 
> missing license/copyright
> 

Will add copyright/license.

> > +#define spi_readl(ds, reg)					\
> > +	readl(ds->regs + DAVINCI_SPI_##reg)
> > +#define spi_writel(ds, reg, value)				\
> > +	writel(value, ds->regs + DAVINCI_SPI_##reg)
> 
> should be (ds)->regs

I'll modify it and resubmit the patch.

Thanks,
Sudhakar