[U-Boot] [PATCH] omap3: beagle: fix compile error

Dirk Behme dirk.behme at googlemail.com
Sat Dec 26 09:08:59 CET 2009


Dear Wolfgang Denk,

On 26.12.2009 00:33, Wolfgang Denk wrote:
> Dear Dirk Behme,
>
> In message<4B3306A7.5010409 at googlemail.com>  you wrote:
>> On 23.12.2009 15:54, Sanjeev Premi wrote:
>>> The configuration for beagle undefs CONFIG_CMD_NET.
>>> This leads to following error:
>>>
>>> lib_arm/libarm.a(board.o): In function `start_armboot':
>>> /home/premi/u-boot/lib_arm/board.c:360: undefined reference
>>>    to `getenv_IPaddr'
>>> make: *** [u-boot] Error 1
>>>
>>> This patch fixes the error by including offending line
>>> in appropriate ifdef.
>>>
>>> Signed-off-by: Sanjeev Premi<premi at ti.com>
>>
>> Acked-by: Dirk Behme<dirk.behme at googlemail.com>
>>
>> Tom: Could we get this applied and sent to Wolfgang asap? Mainline
>> Beagle, Pandora, Zoom1and Zoom2 are broken without this.
>
> Sorry, but I disagree.

I hope you only disagree on the fix Sanjeev (and others, see below) 
proposed? And not that it should be fixed asap?

Please note that other architectures (not only boards) seem to have 
the same issue

http://lists.denx.de/pipermail/u-boot/2009-December/065810.html

Regarding your proposal to implement getenv_IPaddr() for all 
architectures
independent of CONFIG_NET

http://lists.denx.de/pipermail/u-boot/2009-December/065833.html

do you have a proposal where (in which file) this should be done? 
Sounds like it has to be a global function available for all 
architectures?

Best regards

Dirk


More information about the U-Boot mailing list