[U-Boot] [PATCH 1/2] common/console: coding style cleanup
Wolfgang Denk
wd at denx.de
Sun Feb 1 12:32:12 CET 2009
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message <1233486771-10411-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
> common/console.c | 97 ++++++++++++++++++++++++++++--------------------------
> 1 files changed, 50 insertions(+), 47 deletions(-)
>
> diff --git a/common/console.c b/common/console.c
> index 89aeab6..851b0f8 100644
> --- a/common/console.c
> +++ b/common/console.c
> @@ -106,39 +106,39 @@ int cd_count[MAX_FILES];
> * only from fgetc() which assures it.
> * No attempt is made to demultiplex multiple input sources.
> */
> -static int iomux_getc(void)
> +static int iomux_getc (void)
...
> -static int iomux_tstc(int file)
> +static int iomux_tstc (int file)
NAK.
This Linux kernel coding style does NOT insert spaces between
function names; your patch makes the style worse, not better.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human race is faced with a cruel choice: work or daytime tele-
vision.
More information about the U-Boot
mailing list