[U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys

[Kumar Gala]

On Feb 3, 2009, at 2:53 AM, Pieter wrote:

>>
>> static inline void flash_unmap(flash_info_t *info, flash_sect_t sect,
>> 		unsigned int offset, void *addr)
>> {
>> -	unsigned int byte_offset = offset * info->portwidth;
>> -
>> -	unmap_physmem(addr, flash_sector_size(info, sect) - byte_offset);
>> }
> <snip>
>
> Since "flash_unmap(flash_info_t *info, flash_sect_t sect,unsigned  
> int offset, void *addr)" function is empty after applying the patch,  
> should all function calls in the /drivers/mtd/cfi_flash.c file not  
> also be removed?
>
> cheers pieter

I think its best to leave them alone for now.  If in the future we  
really think flash_unmap isn't going to get called we can remove  
them.  Stefan?

- k