[U-Boot] [PATCH 4/9] A driver for the S6E63D6 SPI display controller from Samsung

[Magnus Lilja]

Hi

2009/2/4 Guennadi Liakhovetski <lg at denx.de>:
> This is a driver for the S6E63D6 SPI OLED display controller from Samsung.
> It only provides access to controller's registers so the client can freely
> configure it.
>
> Signed-off-by: Guennadi Liakhovetski <lg at denx.de>
> ---
>  drivers/video/Makefile  |    1 +
>  drivers/video/s6e63d6.c |   68 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/s6e63d6.h       |   36 +++++++++++++++++++++++++
>  3 files changed, 105 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/video/s6e63d6.c
>  create mode 100644 include/s6e63d6.h
>
> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
> index 7fba29f..a7dc74c 100644
> --- a/drivers/video/Makefile
> +++ b/drivers/video/Makefile
> @@ -34,6 +34,7 @@ COBJS-$(CONFIG_VIDEO_SED13806) += sed13806.o
>  COBJS-$(CONFIG_SED156X) += sed156x.o
>  COBJS-$(CONFIG_VIDEO_SM501) += sm501.o
>  COBJS-$(CONFIG_VIDEO_SMI_LYNXEM) += smiLynxEM.o
> +COBJS-$(CONFIG_DISPLAY_S6E63D6) += s6e63d6.o
>  COBJS-y += videomodes.o
>
>  COBJS  := $(COBJS-y)
> diff --git a/drivers/video/s6e63d6.c b/drivers/video/s6e63d6.c
> new file mode 100644
> index 0000000..27ff976
> --- /dev/null
> +++ b/drivers/video/s6e63d6.c
> @@ -0,0 +1,68 @@
> +/*
> + * Copyright (C) 2009
> + * Guennadi Liakhovetski, DEXN Software Engineering, <lg at denx.de>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +#include <common.h>
> +#include <spi.h>
> +#include <s6e63d6.h>
> +
> +/* Hardware selected value - 0 or 0x4 */
> +#define ID 0
> +
> +/*
> + * Each transfer is performed as:
> + * 1. chip-select active
> + * 2. send 8-bit start code
> + * 3. send 16-bit data
> + * 4. chip-select inactive
> + */
> +static int send_word(struct spi_slave *spi, u8 rs, u16 data)
> +{
> +       u32 buf8 = 0x70 | ID | (rs & 2);
> +       u32 buf16 = cpu_to_le16(data);
> +       u32 buf_in;
> +       int err;
> +
> +       err = spi_xfer(spi, 8, &buf8, &buf_in, SPI_XFER_BEGIN);
> +       if (err)
> +               return err;
> +       return spi_xfer(spi, 16, &buf16, &buf_in, SPI_XFER_END);
> +}
> +
> +/* Index and param differ in Register Select bit */
> +int s6e63d6_index(struct s6e63d6 *data, u8 idx)
> +{
> +       return send_word(data->slave, 0, idx);
> +}
> +
> +int s6e63d6_param(struct s6e63d6 *data, u16 param)
> +{
> +       return send_word(data->slave, 2, param);
> +}
> +
> +int s6e63d6_init(struct s6e63d6 *data)
> +{
> +       data->slave = spi_setup_slave(data->bus, data->cs, 100000, SPI_MODE_3);
> +       if (!data->slave)
> +               return 1;
> +
> +       return 0;
> +}
> diff --git a/include/s6e63d6.h b/include/s6e63d6.h
> new file mode 100644
> index 0000000..9665dc5
> --- /dev/null
> +++ b/include/s6e63d6.h
> @@ -0,0 +1,36 @@
> +/*
> + * Copyright (C) 2009
> + * Guennadi Liakhovetski, DEXN Software Engineering, <lg at denx.de>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +#ifndef _S6E63D6_H_
> +#define _S6E63D6_H_
> +
> +struct s6e63d6 {
> +       unsigned int bus;
> +       unsigned int cs;
> +       struct spi_slave *slave;
> +};
> +
> +extern int s6e63d6_init(struct s6e63d6 *);
> +extern int s6e63d6_index(struct s6e63d6 *, u8);
> +extern int s6e63d6_param(struct s6e63d6 *, u16);

'extern' not needed.

Also, personally I prefer to have the parameter names in the
prototypes as well, not just the data types.


Regards, Magnus