[U-Boot] [PATCH 1/9] i.MX31: fix SPI driver for shorter than 32 bit transfers
Wolfgang Denk
wd at denx.de
Wed Feb 4 22:30:32 CET 2009
Dear Guennadi Liakhovetski,
In message <Pine.LNX.4.64.0902041536070.6279 at axis700.grange> you wrote:
> Fix 8 and 16-bit transfers in mxc_spi driver and a wrong pointer in the
> free routine.
>
> Signed-off-by: Guennadi Liakhovetski <lg at denx.de>
> ---
...
> for (i = 0, in_l = (u32 *)din, out_l = (u32 *)dout;
> i < n_blks;
> - i++, in_l++, out_l++, bitlen -= 32)
> - *in_l = spi_xchg_single(slave, *out_l, bitlen);
> + i++, in_l++, out_l++)
> + *in_l = spi_xchg_single(slave, *out_l, flags);
Please use TABs for indentation, and add curly braces because of the
multi-line for construct.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women, and engi-
neers. While the first two are more pleasant, the third is by far the
more certain." - Baron Rothschild, ca. 1800
More information about the U-Boot
mailing list