[U-Boot] [PATCH 2/7] OMAP3: Beagle: Add board revision detection

[Jean-Christophe PLAGNIOL-VILLARD]

>  /******************************************************************************
> + * Routine: board_identify
> + * Description: Detect if we are running on a Beagle revision Ax/Bx or
> + *              Cx. This can be done by GPIO_171. If this is low, we are
> + *              running on a revision C board.
> + *****************************************************************************/
> +void board_identify(void)
> +{
> +	gpio_t *gpio6_base = (gpio_t *)OMAP34XX_GPIO6_BASE;
> +
> +	/* Configure GPIO 171 as input */
we may need to start to think about merge to the gpiolib to simplify it
> +	writel(readl(&gpio6_base->oe) | GPIO11, &gpio6_base->oe);
> +
> +	/* Get value of GPIO 171 */
> +	beagle_revision_c = readl(&gpio6_base->datain) & BOARD_REVISION_MASK;
> +
> +	printf("Board revision ");
> +	if (beagle_revision_c) {
???
I'm not a fan of glabal var please create a function that will return if it's
a rev c or not

Best Regards,
J.